Merged
Conversation
Contributor
Author
|
Random Metrics:
|
sam-goodwin
reviewed
Jul 25, 2022
packages/sagaFunction/README.md
Outdated
| @@ -0,0 +1 @@ | |||
| # replace this No newline at end of file | |||
Contributor
There was a problem hiding this comment.
I like the content in the original pattern. Should we have the same?
sam-goodwin
approved these changes
Jul 25, 2022
Contributor
|
These seem hard to read, do we know the source of these inefficiencies? Both in terms of naming and excessive states?
Equivalent when hand-written without Functionless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on sam-goodwin/functionless#361 (API Gateway Template Formatting)
Based on: https://github.com/cdk-patterns/serverless/tree/main/the-saga-stepfunction
If any steps fail, undo any already executed actions.
ex:
If the payment fails, revert the flight booking and the hotel booking.
Two Constructs;